Skip to content

[skip changelog] Add coverage for legacy tests #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 3, 2019
Merged

[skip changelog] Add coverage for legacy tests #390

merged 2 commits into from
Sep 3, 2019

Conversation

masci
Copy link
Contributor

@masci masci commented Sep 3, 2019 •
edited
Loading

Since we run legacy tests, let's make them contribute to the overall coverage.

@masci masci added status: in progress Work is in progress on this component/testing labels Sep 3, 2019
@masci masci removed the status: in progress Work is in progress on this label Sep 3, 2019
@masci masci changed the title Add coverage for legacy tests [skip changelog] Add coverage for legacy tests Sep 3, 2019
cmaglie
cmaglie approved these changes Sep 3, 2019
View reviewed changes
Copy link
Member

@cmaglie cmaglie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1000

@masci masci merged commit dba2d34 into master Sep 3, 2019
@masci masci deleted the massi/cov branch September 3, 2019 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmaglie cmaglie cmaglie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@masci @cmaglie